Subject: Re: CVS commit: src/sys/dev/pci
To: Jason R Thorpe <thorpej@wasabisystems.com>
From: David Young <dyoung@ojctech.com>
List: source-changes
Date: 12/31/2002 20:54:42
Ok. I will change it.
Looks like there is no compelling reason for wi_pci_attach to write
PCI_COMMAND_STATUS_REG.
Dave
On Tue, Dec 31, 2002 at 06:39:48PM -0800, Jason R Thorpe wrote:
> On Wed, Jan 01, 2003 at 04:36:55AM +0200, dyoung@netbsd.org wrote:
>
> > Module Name: src
> > Committed By: dyoung
> > Date: Wed Jan 1 02:36:55 UTC 2003
> >
> > Modified Files:
> > src/sys/dev/pci: if_wi_pci.c
> >
> > Log Message:
> > For confidence's sake, enable I/O and memory accesses (which were
> > previously NOT enabled), but do not enable bus-mastering (which
> > was previously enabled, but which neither Lucent nor Prism support).
>
> The driver should never mess with the MEM and IO enables of a PCI
> device -- the code that configures the PCI bus will enable MEM and/or
> IO for those devices which have appropriately programmed BARs.
>
> --
> -- Jason R. Thorpe <thorpej@wasabisystems.com>
--
David Young OJC Technologies
dyoung@ojctech.com Engineering from the Right Brain
Urbana, IL * (217) 278-3933