Re: CVS commit: src/usr.bin/fstat

[Simon Burge <simonb%wasabisystems.com@localhost>]

Martin Husemann wrote:

> On Mon, Jan 20, 2003 at 06:16:15PM +1100, Simon Burge wrote:
> 
> > The "z" modifier handles size_t (eg, "%zd").  off_t can use PRId64
> > from <inttypes.h> but it's a little ugly.
> 
> I was more thinking of defining our own PRIoff_t to make it independend
> of the 64bit assumption, but thats a portability drawback and probably not
> worth it.
> 
> If this is considered the way to go, we should hunt for all %lld and 
> similar things, fix them and remove the bogus casts now in use ~everywhere.
> 
> OK if I do that, test on sparc64 & i386 and commit?

Those two should be a good test.  This sounds like a reasonable plan to
me.  You may want to look for %llu and field widths as well, so maybe a
regex like '%ll[0-9]*(u|d)' ...

Simon.
--
Simon Burge                            <simonb%wasabisystems.com@localhost>
NetBSD Support and Service:         http://www.wasabisystems.com/