Re: CVS commit: src/sys/arch/i386/i386

["Ross Harvey" <ross%netbsd.org@localhost>]

> From: "Perry E. Metzger" <perry%piermont.com@localhost>
>
> I don't think this is quite right. Among other things, it violates
> power control -- one really wants to run HLT in the loop, I think.


That's a good idea. (Mine was, ahem, reviewed first.) If you really
want to make a masterpiece out of something that may never run,
export something like

    int cnattached(void) { return cn_tab != NULL; }

from dev/cons.c and use the result to suppress the hit-any-key
message and the getc() return value test, maybe wrap the halt op,
perhaps void out your Palladium (err, NGSCB) authorization... :-)


> Also, why the "continue" instead of just "for (;;);"?


Ahh, see /usr/share/misc/style, line 229.



> Ross Harvey <ross%netbsd.org@localhost> writes:
>
> > Module Name:        src
> > Committed By:       ross
> > Date:               Thu Feb 13 21:34:04 UTC 2003
> > 
> > Modified Files:
> >     src/sys/arch/i386/i386: machdep.c
> > 
> > Log Message:
> > If no keyboard is attached, implement RB_HALT with a spin.  kern/10481
> > 
> > 
> > To generate a diff of this commit:
> > cvs rdiff -r1.510 -r1.511 src/sys/arch/i386/i386/machdep.c