CVS commit: src/usr.bin/mail

["Perry E. Metzger" <perry%netbsd.org@localhost>]

Module Name:    src
Committed By:   perry
Date:           Sat Mar 29 21:27:38 UTC 2003

Modified Files:
        src/usr.bin/mail: popen.c

Log Message:
Fix a bug introduced by Christos Zoulas in version 1.4.
He accidently moved the call to block the SIGCHLD to the wrong side of
the call to findchild().
Caused a coredump in one in every N thousand invocations of mail,
which I have been hunting for literally years.
Fixes PR 19696 from Mason Loring Bliss, too.

By the way, this is a prime example of why declarations of the form

struct foo *p = funcall();

are pure liquid evil.


To generate a diff of this commit:
cvs rdiff -r1.14 -r1.15 src/usr.bin/mail/popen.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.