Subject: Re: CVS commit: src/sys/dev/ic
To: None <dyoung@netbsd.org>
From: Jason Thorpe <thorpej@wasabisystems.com>
List: source-changes
Date: 05/13/2003 07:00:01
On Tuesday, May 13, 2003, at 01:35 AM, dyoung@netbsd.org wrote:
> 2 Adopt the macros WI_LOCK/WI_UNLOCK for synchronization. FreeBSD
> uses a different synchronization mechanism.
Please tell me that you're not removing the existing spl*() stuff from
the driver, and that the WI_{LOCK,UNLOCK}macros are just noop stubs.
Our synchronization *semantics* are also different from FreeBSD, and
blindly making a driver match is likely to cause problems.
> 5 Bug fix: if IFF_ALLMULTI, don't filter any multicasts.
Our IFF_ALLMULTI semantics are different from FreeBSD; making a
driver's IFF_ALLMULTI handling match FreeBSD is broken by definition.
-- Jason R. Thorpe <thorpej@wasabisystems.com>