Subject: Re: CVS commit: src/sys/dev/pcmcia
To: enami tsugutomo <enami@sm.sony.co.jp>
From: Charles M. Hannum <abuse@spamalicious.com>
List: source-changes
Date: 10/22/2003 14:34:45
On Wednesday 22 October 2003 11:09 am, enami tsugutomo wrote:
> Allen Briggs <briggs@NetBSD.org> writes:
> > Module Name: src
> > Committed By: briggs
> > Date: Wed Oct 22 07:48:25 UTC 2003
> >
> > Modified Files:
> > src/sys/dev/pcmcia: wdc_pcmcia.c
> >
> > Log Message:
> > Since we enable the pcmcia function on attach, disable it on the detach.
>
> No. Your change is wrong. The reason why enable/disable become
> unbalance is because now real wd probe/attach jobs is done via atabus
> kernel thread and wdcattach itself returns after creating the kernel
> thread. So, the correct fix is to disable the device when exiting
> wdc_pcmcia_attach().
Oy. This means another power up/down cycle of the PCMCIA card to attach the
disks. This is very slow. I purposefully avoided that in my previous
changes.