Subject: Re: CVS commit: src/sys/sys
To: Jaromir Dolecek <jdolecek@NetBSD.org>
From: Bill Studenmund <wrstuden@netbsd.org>
List: source-changes
Date: 11/07/2003 09:45:36
--AqsLC8rIMeq19msA
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Nov 07, 2003 at 12:19:18PM +0100, Jaromir Dolecek wrote:
> Bill Studenmund wrote:
> > You changed field names and deleted one. You really should bump the
> > version. The point isn't just that you kept struct proc's layout the sa=
me,
> > it's that you renamed something.
> >=20
> > While you've done an excelent job of maintaining binary compatability, =
you
> > have broken source compatability. The packages I'm familiar with that t=
ry=20
> > to keep lkms and drivers up to date use defines based on kernel version=
.=20
> > This change makes it so that that behavior (defines) doesn't work.
>=20
> This change doesn't affect LKMs in any way. These fields were
> private kernel only, only used by the actual RAS code.

Are you sure?

You are talking about the RAS code, but David changed more than that. He=20
changed the name of the lock on all of struct proc. That is used outside=20
of just the RAS code.

Take care,

Bill

--AqsLC8rIMeq19msA
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (NetBSD)

iD8DBQE/q9pAWz+3JHUci9cRAmOPAJ932v/UF9n5z2Oo/mxRjKZZheyacgCfRt4C
ddionrtHTB0yA+Y/eEXBT/4=
=6A/Z
-----END PGP SIGNATURE-----

--AqsLC8rIMeq19msA--