Subject: re: CVS commit: src/sys/arch/hp700/include
To: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
From: matthew green <mrg@eterna.com.au>
List: source-changes
Date: 11/09/2003 11:31:14
In article <18380.1068300286@splode.eterna.com.au>
mrg@eterna.com.au wrote:
> Log Message:
> Include "opt_lockdebug.h" only #if !defined(_LKM) && defined(_KERNEL_OPT).
>
>
> that should be just if defined(_KERNEL_OPT).
Umm, then I refered a bad example (sparc/include/cpu.h). I'll fix them.
BTW, some other files use:
/sys/arch/arm/include/bus.h:#if defined(_KERNEL) && !defined(_LKM)
/sys/arch/i386/include/pcb.h:#if defined(_KERNEL) && !defined(_LKM)
/sys/arch/sparc64/include/cpu.h:#if !defined(_LKM)
for opt_xxx.h, but all of them should be use _KERNEL_OPT too?
right. kernel options headers are to be included if _KERNEL_OPT.
this is because we used to use _KERNEL && !_LKM but that is just
wrong. :-) (the !_LKM bit was added due to the userland programs
that #define _KERNEL to see Stuff in header files.)
.mrg.