Subject: Re: CVS commit: src/usr.sbin/installboot
To: Luke Mewburn <lukem@NetBSD.org>
From: James Chacon <jmc@NetBSD.org>
List: source-changes
Date: 11/13/2003 21:57:26
On Fri, Nov 14, 2003 at 11:58:28AM +1100, Luke Mewburn wrote:
> On Fri, Nov 14, 2003 at 01:01:18AM +0300, Valeriy E. Ushakov wrote:
> | Including sys/disklabel.h in a host tool is a very bad idea, because
> | even though NetBSD's sys/disklabel.h is used, it, in turn, includes
> | machine/disklabel.h - which doesn't exist if you cross build on some
> | other system.
>
> I concur; this is precisely why <sys/bootblock.h> was implemented.
As an FYI this will basically break any cross-compiles hosting on a non
*BSD platform (i.e. linux/solaris/etc) until it's fixed.
James