Subject: Re: CVS commit: src/sys/arch/cobalt/stand/boot
To: None <tsutsui@ceres.dti.ne.jp>
From: Havard Eidnes <he@netbsd.org>
List: source-changes
Date: 12/14/2003 11:30:06
> > Modified Files:
> > 	src/sys/arch/cobalt/stand/boot: wd.c
> > =

> > Log Message:
> > Adapt to rename of WDC_CAP_LBA48 to ATA_CMD2_LBA48 in atareg.h,
> > and don't use types which will be promoted when passed as ...,
> > causing a warning.
>
> Isn't it better to change types for all unit/part variables
> to use u_int (not only for va_arg())?

That may be.  In this round I went for the minimal change,
partially because I have no way of testing the result, other than
"cross-compiles with no warning".

> I posted a patch to port-cobalt/23711:
> http://www.netbsd.org/cgi-bin/query-pr-single.pl?number=3D23711
> but I have not confirmed it working. (I'll try it shortly)

Thanks, that would be appreciated.  As you might guess, I wasn't
aware of the PR and the ensuing discussion.

Regards,

- H=E5vard