Subject: Re: CVS commit: src/sys/dev/pcmcia
To: David Young <dyoung@pobox.com>
From: Christos Zoulas <christos@zoulas.com>
List: source-changes
Date: 12/27/2003 19:36:02
On Dec 27, 6:20pm, dyoung@pobox.com (David Young) wrote:
-- Subject: Re: CVS commit: src/sys/dev/pcmcia
| I know what bug you are trying to fix. You have only just scratched
| the surface. See, for example, comments in tcic_chip_io_map (and
| elsewhere?) saying, /* XXX wtf is this doing here? */.
Very annoying... How about changing tcic2.c to:
--- tcic2.c.orig 2003-11-05 20:24:22.000000000 -0500
+++ tcic2.c 2003-12-27 19:34:48.000000000 -0500
@@ -1210,9 +1210,10 @@
/* XXX wtf is this doing here? */
- printf(" port 0x%lx", (u_long) ioaddr);
+ printf("%s: port 0x%lx", h->sc->dev.dv_xname, (u_long) ioaddr);
if (size > 1)
printf("-0x%lx", (u_long) ioaddr + (u_long) size - 1);
+ printf("\n");
h->io[win].addr = ioaddr;
h->io[win].size = size;
christos