Subject: Re: CVS commit: src/sys/arch/i386
To: None <lukem@netbsd.org>
From: Bang Jun-Young <junyoung@NetBSD.org>
List: source-changes
Date: 04/30/2004 16:00:43
Luke Mewburn wrote:
> Module Name:	src
> Committed By:	lukem
> Date:		Fri Apr 30 02:05:43 UTC 2004
>
> Modified Files:
> 	src/sys/arch/i386/conf: files.i386
> 	src/sys/arch/i386/i386: cpu.c est.c identcpu.c machdep.c
> 	src/sys/arch/i386/include: cpu.h
>
> Log Message:
> Integrate support for Enhanced SpeedStep Technology (est) that
> Michael Eriksson posted to port-i386 on 20031102, with various
> modifications by me to work in the new sysctl(9) framework.
>
> The code is enabled with 'options ENHANCED_SPEEDSTEP', and if
> the CPU supports EST the following sysctl(8) nodes appear
> (with the values that a Dell Inspiron 8600 + WUXGA with a
> 1.4GHz Pentium M CPU supports):
> 	machdep.est.cpu_brand = Intel(R) Pentium(R) M processor 1400MHz

Wouldn't it better to elevate it to machdep.cpu_brand? It's not est 
specific.

Jun-Young