--ISKrrfpKsPiF35CV
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Jun 07, 2004 at 05:36:38PM +0000, YAMAMOTO Takashi wrote:
>=20
> Module Name:	src
> Committed By:	yamt
> Date:		Mon Jun  7 17:36:38 UTC 2004
>=20
> Modified Files:
> 	src/sys/miscfs/genfs: layer_extern.h layer_vnops.c
> 	src/sys/miscfs/nullfs: null_vnops.c
> 	src/sys/miscfs/overlay: overlay_vnops.c
> 	src/sys/miscfs/umapfs: umap_vnops.c
>=20
> Log Message:
> do a LAYERFS_REMOVED hack for vop_rename as well.

I don't think the following test is needed:

              if (tvp->v_mount !=3D fdvp->v_mount)
                      tvp =3D NULL;
              else
                      vref(tvp);

as VOP_RENAME() is not intended to support cross-mount renames; any call=20
that ever did that would be an error.

My only concern with leaving the test in is that it might imply to some=20
future programmers that they need to worry about a cross-mount rename.

Take care,

Bill

--ISKrrfpKsPiF35CV
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (NetBSD)

iD8DBQFAyO3aWz+3JHUci9cRAqgSAJ90thLD7Db9UWmxi7j1xY8b9mPwpACdFyHc
cGXrSrdAzTdDrEFtkQtOVaM=
=Kvol
-----END PGP SIGNATURE-----

--ISKrrfpKsPiF35CV--