Subject: Re: CVS commit: src/sys/miscfs
To: YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp>
From: Bill Studenmund <wrstuden@netbsd.org>
List: source-changes
Date: 06/16/2004 18:32:53
--NklN7DEeGtkPCoo3
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jun 17, 2004 at 08:56:06AM +0900, YAMAMOTO Takashi wrote:
> > Module Name:	src
> > Committed By:	wrstuden
> > Date:		Wed Jun 16 17:59:53 UTC 2004
> >=20
> > Modified Files:
> > 	src/sys/miscfs/genfs: layer_vnops.c
> > 	src/sys/miscfs/umapfs: umap_vnops.c
> >=20
> > Log Message:
> > Make sure we actually locked the parent vnode before we clear
> > PDIRUNLOCK. The whole reason we have the flag is to note (rare)
> > cases where we are supposed to have the parent directory locked
> > but don't. Permits error handling code to know what to do with
> > the parrent vnode (vrele() vs vput()).
>=20
> how can vn_lock(LK_EXCLUSIVE | LK_RETRY) fail in this case?

Somehow the lock is dying. Yes, for it to happen we have to have
wandered into the weeds, but this code methodology is to try and help us=20
get somewhere a bit safer. i.e. not add more error states on top if we=20
don't have to.

Take care,

Bill

--NklN7DEeGtkPCoo3
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (NetBSD)

iD8DBQFA0PTFWz+3JHUci9cRArvYAJsHXqhuBpHajP/4s7Im7GCoczhwVACfTmDX
NI6WI9wCLCPeHAHEgvIxDNw=
=EzR5
-----END PGP SIGNATURE-----

--NklN7DEeGtkPCoo3--