Subject: Re: CVS commit: src/sys/miscfs/genfs
To: YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp>
From: Bill Studenmund <wrstuden@netbsd.org>
List: source-changes
Date: 06/20/2004 15:30:30
--ReaqsoxgOBHFXBhH
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Sun, Jun 20, 2004 at 02:15:24PM +0900, YAMAMOTO Takashi wrote:
> > Actually I think it is about time we rip out the shadow locking that
> > layered file systems are doing. When it was added, a number of file
> > systems (nfs, kernfs, procfs) didn't do real node locking; they used
> > genfs_nolock(). Now there are very few uses of genfs_nolock(), so I thi=
nk
> > we can just remove it.
>=20
> what's the "shadow locking" do you mean?
LAYERFS_UPPERLOCK(), LAYERFS_UPPERUNLOCK(), and LAYERFS_UPPERISLOCKED().=20
They were for when NFS and other fs's didn't do real locking.
Now, the only real fs that doesn't export a struct lock is union, and it=20
does real locking on its own. So I don't think these are needed.
Take care,
Bill
--ReaqsoxgOBHFXBhH
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (NetBSD)
iD8DBQFA1hAGWz+3JHUci9cRAombAKCMBNYvfKbaNjQhmIt1S/TuEBFxUQCgjPvP
PQlhYBVYc/fhA65ysL63kpU=
=badJ
-----END PGP SIGNATURE-----
--ReaqsoxgOBHFXBhH--