Subject: Re: CVS commit: src/sys/sys
To: Christoph Badura <bad@bsd.de>
From: Bill Studenmund <wrstuden@netbsd.org>
List: source-changes
Date: 07/06/2004 17:30:10
--wac7ysb48OaltWcw
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Tue, Jul 06, 2004 at 11:29:21PM +0200, Christoph Badura wrote:
> On Fri, Jun 25, 2004 at 03:23:57PM +0000, Jun-ichiro itojun Hagino wrote:
> >=20
> > Module Name: src
> > Committed By: itojun
> > Date: Fri Jun 25 15:23:57 UTC 2004
> >=20
> > Modified Files:
> > src/sys/sys: mbuf.h
> >=20
> > Log Message:
> > null out m_pkthdr.rcvif on MGETHDR. otherwise we will touch unexpected
> > memory region on m->m_pkthdr.rcvif access (NULL is at least debuggable =
than
> > random junk value).
>=20
> Should this be #ifdef DIAGNOSTIC or DEBUG?
Why? We're initing a bunch of stuff, so it seems easiest to just set this=
=20
to NULL too.
Take care,
Bill
--wac7ysb48OaltWcw
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (NetBSD)
iD8DBQFA60QSWz+3JHUci9cRAiF+AJ9fm+RFiW2zfJPlQfu8SzYaD8LvoACdEAOI
m8FdSnZtsDxAkOTH91Ua5u0=
=xY+Y
-----END PGP SIGNATURE-----
--wac7ysb48OaltWcw--