Subject: Re: CVS commit: src/sys/kern
To: None <source-changes@netbsd.org>
From: Wolfgang Solfrank <ws@tools.de>
List: source-changes
Date: 11/17/2004 16:13:13
Hi,
Matt Thomas wrote:
> Module Name: src
> Committed By: matt
> Date: Thu Nov 4 23:55:28 UTC 2004
>
> Modified Files:
> src/sys/kern: exec_script.c
>
> Log Message:
> Check to see if the script has an ELF header, and if so, return ENOEXEC.
Hmm, I'm probably makeing myself a fool again, but how would this ever be
triggered? hdrstr was strncmp'ed against EXEC_SCRIPT_MAGIC a few lines above,
and neither does ELFMAG start with EXEC_SCRIPT_MAGIC, nor was hdrstr modified
in between (except a possible truncation of the string which doesn't matter).
IMHO, this should be backed out.
Ciao,
Wolfgang
--
ws@TooLs.DE Wolfgang Solfrank, TooLs GmbH