--UugvWAfsgieZRqgk
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, May 02, 2005 at 01:52:52AM +0900, Izumi Tsutsui wrote:
> In article <20050501162107.DB86D2DA27@cvs.netbsd.org>
> riz@netbsd.org wrote:
>=20
> > Modified Files:
> > 	src/gnu/dist/gettext/gettext-tools/src: po-lex.c
> >=20
> > Log Message:
> > Only test if a char is >=3D 0x00 when CHAR_MIN is < 0, so gcc doesn't
> > warn about the comparison always being true.  Fixes build for macppc
> > target.
>=20
> Isn't it better to test ((mbc->buf[0] & 0x80) =3D=3D 0) for readability
> if it checks control characters?

Possibly - to be frank, I'm almost completely unfamiliar with gettext,
and since this is externally-maintained src, I addressed the issue in
the same way it had been addressed elsewhere in the file.  (Apparently, they
missed one)

I certainly wouldn't object if someone else wanted to fix it "better".

+j

--UugvWAfsgieZRqgk
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (NetBSD)

iQCVAwUBQnUTFrOuUtxCgar5AQIHhAQArbSl0NRQYApQiNfMLbe81yamhmFXtUrg
nySJQZI4EbnH/qDVKPR9TmGuBZlpIZWutj+6Qa/iX7WSGanoQEK2yP8xxLeyoKys
AOLPlVFf1E6EDMFwEH2zWe/bcHBsz67vJhzU9xQ7SCdLyOZx0AWTuUoe79VkWTNH
Fb1CzkBSWos=
=QAvU
-----END PGP SIGNATURE-----

--UugvWAfsgieZRqgk--