Subject: Re: CVS commit: src/sys/sys
To: matthew green <mrg@eterna.com.au>
From: Simon Burge <simonb@wasabisystems.com>
List: source-changes
Date: 06/08/2005 12:14:20
matthew green wrote:
> all this is missing my point that "bufpages" has been a global in
> the kernel since day0 -- do you want to remove that? if it's
> kernel global, it should have a public header declaring it. i
> don't like local "extern"s for globals.
bufpages notwithstanding, I definitely agree with Matt that local
"externs" are a bad thing. Variables can change types over time, and
these externs may cause problems if not updated, possibly in subtle
ways.
Simon.
--
Simon Burge <simonb@wasabisystems.com>
NetBSD Support and Service: http://www.wasabisystems.com/