On Jun 14, 2005, at 11:00 PM, Bang Jun-Young wrote:

> 2. S_SIZE() should haven't been introduced in the first place,  
> since it
> was only used twice across the tree. The above line can be written as
>
>             const char *sig = "PXENV+";
>             ...
>             if (memcmp(pxenv->Signature, sig, sizeof(sig)))

That should be written:

     const char sig[] = "PXENV+";

in order for that to work.

>
> Now you don't need to check what MEMSTRCMP() macro is expanded into or
> what S_SIZE() is.
>
> Jun-Young
>
>
>
>

-- thorpej