Subject: Re: CVS commit: src/sys/kern
To: YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp>
From: Christos Zoulas <christos@zoulas.com>
List: source-changes
Date: 09/06/2005 12:14:39
On Sep 6, 11:03am, yamt@mwd.biglobe.ne.jp (YAMAMOTO Takashi) wrote:
-- Subject: Re: CVS commit: src/sys/kern
| > Module Name: src
| > Committed By: christos
| > Date: Tue Aug 23 07:58:58 UTC 2005
| >
| > Modified Files:
| > src/sys/kern: kern_prot.c
| >
| > Log Message:
| > in setgroups(), sort -u the gid_t array to make sure that comparisons are
| > consistent.
|
| - why not use nfsrvw_sort?
I was not aware of this routine. It uses insertion sort which is
better in this case, but it does not eliminate duplicate entries.
| - if "comparisons" means crcmp, you need to sort gids in crcvt.
I will add that.
christos