Subject: Re: CVS commit: src/sys/dev/ic
To: None <david@l8s.co.uk>
From: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
List: source-changes
Date: 09/11/2005 05:09:23
david@l8s.co.uk wrote:
> > Whele here, change style of some byteswap ops from
> > foo = bar();
> > foo = ahc_htole32(foo);
> > to
> > foo = ahc_htole32(bar());
>
> That is likely to break the code.
> The underlying htole32() code could easily be a #define that
> evalautes its argument more than once.
IMHO, such macro is broken and should be fixed.
Anyway, most our other drivers use the latter.
---
Izumi Tsutsui