Subject: Re: CVS commit: src/usr.bin/find
To: Quentin Garnier <cube@cubidou.net>
From: James Chacon <jmc@NetBSD.org>
List: source-changes
Date: 10/19/2005 13:38:01
On Wed, Oct 19, 2005 at 02:23:45PM +0200, Quentin Garnier wrote:
> On Wed, Oct 19, 2005 at 12:17:22PM +0000, Elad Efrat wrote:
> >
> > Module Name: src
> > Committed By: elad
> > Date: Wed Oct 19 12:17:22 UTC 2005
> >
> > Modified Files:
> > src/usr.bin/find: main.c
> >
> > Log Message:
> > Strip trailing slashes before using the path.
> > PR/31869.
>
> That's completely bogus.
>
> find /
> find /somedir/ /someotherdir/
>
> clearly don't work as expected. Please back this out.
>
Yeah, blindly stripping all /'s off until you find something else isn't
the way to go.
(and this code underflows with just "/")
I agree stripping extraneous /'s off makes sense but do it sanely. (and add
a regress test)
James