Subject: Re: CVS commit: src/sys/dev/usb
To: Simon Burge <simonb@wasabisystems.com>
From: Lennart Augustsson <lennart@augustsson.net>
List: source-changes
Date: 11/23/2005 08:34:27
Simon,
I applied the USB related changes because they looked
good to me. I think the other half is good too, but
I can't test it. Feel free to apply the other half
if you think it looks good.
-- Lennart
Simon Burge wrote:
> Hi Lennart,
>
> Lennart Augustsson wrote:
>
>
>>Module Name: src
>>Committed By: augustss
>>Date: Mon Nov 14 13:40:24 UTC 2005
>>
>>Modified Files:
>>
>> src/sys/dev/usb: ohci.c ohcivar.h
>>
>>Log Message:
>>
>>Make it possible to decide endianess dynamically. From port-evbmips/31912
>>by "Garrett D'Amore" <garrett_damore@tadpole.com>.
>
>
> There were two sets of patches in the PR, and unfortunately you've
> committed the first set which don't work in little-endian mode on the
> Alchemy CPU. I've confirmed that the latter set of patches work fine on
> both big- and little-endian Alchemy CPUs but I don't have any other sort
> of machine here with OHCI, just UHCI. The second set of patches remove
> the OHCI_DYNAMIC_ENDIAN conditional, so they should be double checked to
> work on non-Alchemy OHCI controllers too.
>
> Is the second set of patches in that PR ok to apply, or can you commit
> them if you're happy with them?
>
> Simon.
> --
> Simon Burge <simonb@wasabisystems.com>
> NetBSD Support and Service: http://www.wasabisystems.com/
>