On Dec 7,  7:59am, yamt@mwd.biglobe.ne.jp (YAMAMOTO Takashi) wrote:
-- Subject: Re: CVS commit: src/sys/sys

| > Module Name:	src
| > Committed By:	christos
| > Date:		Sat Dec  3 17:10:47 UTC 2005
| > 
| > Modified Files:
| > 	src/sys/sys: cc_microtime.h cpu_data.h disklabel_gpt.h drvctlio.h
| > 	    dvdio.h ieee754.h ioctl_compat.h joystick.h lwp.h null.h once.h
| > 	    sa.h savar.h systrace.h timex.h tprintf.h tty.h workqueue.h
| > 
| > Log Message:
| > Make sure that multiple header inclusion is done, it uses consistent names,
| > and it is around the whole code of the file, not parts of it.
| 
| -#endif /* !defined(_SYS_WORKQUEUE_H_) */
| +#endif /* _SYS_WORKQUEUE_H_ */
| 
| -#endif /* !_SYSTRACE_H_ */
| +#endif /* !_SYS_SYSTRACE_H_ */
| 
| it seems inconsistent about "!" in the comments.  which is your intention?

I think that /* !_SYS_SYSTRACE_H_ */ is the correct comment. I screwed up
some of them, and I will fix them. Initially I thought that leaving most
of the headers alone was a good idea (and most of them have /* _FOO_H_ */
instead of /* !_FOO_H_ */), but fixing it properly is better in the long run.

christos