Subject: Re: CVS commit: src/sys/dev/acpi
To: matthew green <mrg@eterna.com.au>
From: Quentin Garnier <cube@cubidou.net>
List: source-changes
Date: 12/13/2005 02:07:30
--N+qDRRsDvMgizTft
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Dec 13, 2005 at 11:31:38AM +1100, matthew green wrote:
>=20
>   =20
>    Module Name:	src
>    Committed By:	cube
>    Date:		Mon Dec 12 15:04:50 UTC 2005
>   =20
>    Modified Files:
>    	src/sys/dev/acpi: acpi.c acpivar.h
>    	src/sys/dev/acpi/acpica/Osd: OsdEnvironment.c
>   =20
>    Log Message:
>    Move the (one liner) logic of AcpiOsGetRootPointer() out of acpica/Osd=
 to
>    acpi.c and take the opportunity to create a sysctl node that contains =
the
>    address of the main ACPI table.
>   =20
>    The name of the node, "machdep.acpi_root", is questionable but matches=
 the
>    one FreeBSD has, which will make it easier to port their acpidump(8)
>    program.
>=20
>=20
> regardless of what freebsd uses, "machdep" in MD code seems wrong.

Hence my comment about it being questionable; making it go as
hw.acpi_root or hw.acpi.root or whatever is not a hard task, and will
not really make anything else complicated.

Any suggestion about something everyone would agree on?  At least that
one has a precedent :)

One thing should be noted:  FreeBSD creates that node in MD code,
although in the end it is used by a MI userland program, and the data
type involved is 64-bit long whichever the arch is.

--=20
Quentin Garnier - cube@cubidou.net - cube@NetBSD.org
"When I find the controls, I'll go where I like, I'll know where I want
to be, but maybe for now I'll stay right here on a silent sea."
KT Tunstall, Silent Sea, Eye to the Telescope, 2004.

--N+qDRRsDvMgizTft
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (NetBSD)

iQEVAwUBQ54e0dgoQloHrPnoAQJtnAf5AXbyXJ35EN6KpjH8aZpggMTDy9+fPA+7
3VDbKOpvSpOkuzwn6VvbcNUN9zGG62dsx/tI7IfoCix/XE/LmcQL2CPaUkftl6ki
TIbpTpIZriZsIntbaA/IObCOa5SZFbtBUgrnz6iqI9bOuM13jSHs0FnJNFlRlXIb
2pLm1R50KzVxr47BjiiaiDvQ2tWcrTyxnPXs9PMpHf/x3vaKCvlTwLrUjxcahY+T
wkYNF3GH+DuEF6qit25tRm/RKgTCgvTVBL7z+QaushsydMmk7eolPetvQBaP0SqZ
G0mnoJxThudDnfpaqhS0XuBXM+53T7XnXRJ7GdK+PpcTYefcgVAFmg==
=upGU
-----END PGP SIGNATURE-----

--N+qDRRsDvMgizTft--