Subject: Re: CVS commit: src/sys/dev/ic
To: Jaromir Dolecek <jdolecek@NetBSD.org>
From: john heasley <heas@netbsd.org>
List: source-changes
Date: 01/02/2006 10:31:43
Mon, Jan 02, 2006 at 06:11:48PM +0100, Jaromir Dolecek:
> On Mon, Jan 02, 2006 at 05:46:25AM +0000, john heasley wrote:
> >=20
> > Module Name: src
> > Committed By: heas
> > Date: Mon Jan 2 05:46:25 UTC 2006
> >=20
> > Modified Files:
> > src/sys/dev/ic: gem.c
> >=20
> > Log Message:
> > Contribute to the rnd entropy pool (already attached as a source).
>=20
> The call should probably be only made if the interrupt is
> actually claimed by gem_intr().
The top 26 bits potentially have a non-zero value when the interrupt is
not ours. Obviously that could repeat if a chatty device shared the
interrupt. Does that diminish it's value?
fwiw, I took the method from hme. Other drivers do as you suggest and
some just avoid adding a zero value. Clue welcome :)