Subject: Re: CVS commit: src/sys/arch/evbppc/explora
To: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
From: Juergen Hannken-Illjes <hannken@eis.cs.tu-bs.de>
List: source-changes
Date: 01/08/2006 17:11:16
On Sun, Jan 08, 2006 at 10:02:24PM +0900, Izumi Tsutsui wrote:
> In article <20051231140902.3422E2DA27@cvs.netbsd.org>
> hannken@NetBSD.org wrote:
>
> > Modified Files:
> > src/sys/arch/evbppc/explora: machdep.c
> >
> > Log Message:
> > Use our own function to copy traps. We cannot use memcpy() anymore
> > because the destination may be zero.
>
> Isn't it better to disable _DIAGASSERT()'s in
> src/common/lib/libc/string/bcopy.c on building libkern?
> arch/powerpc/oea/oea_machdep.c may have the same problem.
From a quick grep only amigappc, explora, oea and walnut initialize the
reserved trap vector 0x0. I think it is better to special case one
occurence per machine and have a diagnostic for >99% of the memcpy's.
We could install a powerpc-generic function in powerpc/include/trap.h
useable by all powerpc machines.
--
Juergen Hannken-Illjes - hannken@eis.cs.tu-bs.de - TU Braunschweig (Germany)