Subject: Re: CVS commit: src/sys/nfs
To: None <source-changes@netbsd.org>
From: Rui Paulo <rpaulo@fnop.net>
List: source-changes
Date: 03/01/2006 19:29:24
christos@astron.com (Christos Zoulas) writes:

> In article <20060301153012.3D87F2DA27@cvs.netbsd.org>,
> Rui Paulo  <rpaulo@netbsd.org> wrote:
>>
>>Module Name:	src
>>Committed By:	rpaulo
>>Date:		Wed Mar  1 15:30:12 UTC 2006
>>
>>Modified Files:
>>	src/sys/nfs: nfs_socket.c
>>
>>Log Message:
>>From FreeBSD SA-06:10
>>	Correct a remote kernel panic when processing zero-length RPC records
>>	via TCP.
>>
>>
> 			slp->ns_reclen = recmark & ~0x80000000;
> 			[...]
>                         if (slp->ns_reclen > NFS_MAXPACKET
>                             || slp->ns_reclen <= 0) {
>  
> How can slp->ns_reclen be negative? I think that you only care about the
> 0 case, right?

Right, I didn't notice that. Thanks

-- 
  Rui Paulo			<rpaulo@{NetBSD{,-PT}.org,fnop.net}>