Subject: Re: CVS commit: src/sys
To: YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp>
From: Jason Thorpe <thorpej@shagadelic.org>
List: source-changes
Date: 03/05/2006 17:26:19
On Mar 5, 2006, at 4:07 PM, YAMAMOTO Takashi wrote:
>> Log Message:
>> Add a proc_is_traced_p() macro and use it, instead of copying the
>> same code
>> in many places. Idea from thorpej.
>
> isn't it better to make it a real function?
> otherwise, it's prone to have "missing opt_*.h include" type problems.
>
> btw, i think you need to tweak "#if defined(KTRACE) || defined
> (SYSTRACE)"
> around syscall_fancy.
Christos committed this before I did, and my patch is more complete.
I will be checking in my patch shortly, after resolving all of the
conflicts.
Please, no one else touch this stuff for a short time. thanks.
>
> YAMAMOTO Takashi
-- thorpej