Subject: Re: CVS commit: src/sys/arch/amd64/include
To: Simon Burge <simonb@wasabisystems.com>
From: Quentin Garnier <cube@cubidou.net>
List: source-changes
Date: 03/06/2006 22:03:03
--6xYB43uKmzPz9Vks
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Mar 07, 2006 at 07:34:57AM +1100, Simon Burge wrote:
> Quentin Garnier wrote:
>=20
> > Module Name:	src
> > Committed By:	cube
> > Date:		Mon Mar  6 08:30:44 UTC 2006
> >=20
> > Modified Files:
> >=20
> > 	src/sys/arch/amd64/include: cpu.h
> >=20
> > Log Message:
> >=20
> > delay() is gone, so don't declare it.  That way other parts of code that
> > use a variable named delay (say, netinet6/in6.c) won't shadow something
> > that doesn't exist anyway.
>=20
> delay() is used in many parts of MI code.  Given delay(9), shouldn't
> local variables named "delay" be renamed instead?

Sure, that doesn't mean we can't clean up.  There's no actual function
named delay() in amd64, it's just a left over of some old i386 code.

It was the easy way out for me, I agree :)

--=20
Quentin Garnier - cube@cubidou.net - cube@NetBSD.org
"When I find the controls, I'll go where I like, I'll know where I want
to be, but maybe for now I'll stay right here on a silent sea."
KT Tunstall, Silent Sea, Eye to the Telescope, 2004.

--6xYB43uKmzPz9Vks
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (NetBSD)

iQEVAwUBRAyjh9goQloHrPnoAQIwAQgArguZuVM2wH5jILouhGN+UlsTOcC9gsIX
DZov69h3IvIRxD8bhdqy0EQN79g6ELo5TdIe8BHlBJss6jqex04bmmNRqFRHUBL/
7hgA/qY94Vt68/5R9J7WuaoylnpodBIMakVPqA8agCvsBxLBlSNegVy8HvRHauZ4
tvaXYatliLs2DlQEMz7g73BFP7sc4O6WsNCNNfNHvn4I96xjFq01t9VW5Ba6OysS
2YNNN7W8QV5aHHOY0aPp/rIbzUEmxddjm7OIJyQN5pMOQEdlumC0A8Ry8cgCVTBC
NLN9i/NK4pPKe7GwrWvCWZ0zwWRUXm6P7akF3SUXnoIC6u1m2agDrg==
=S25z
-----END PGP SIGNATURE-----

--6xYB43uKmzPz9Vks--