Subject: Re: CVS commit: src/sys/arch/mips/alchemy/dev
To: Simon Burge <simonb@wasabisystems.com>
From: Garrett D'Amore <garrett_damore@tadpole.com>
List: source-changes
Date: 03/06/2006 13:54:22
Simon Burge wrote:
> Shigeyuki Fukushima wrote:
>
>
>> Module Name: src
>> Committed By: shige
>> Date: Mon Mar 6 17:12:24 UTC 2006
>>
>> Added Files:
>>
>> src/sys/arch/mips/alchemy/dev: smbusreg.h
>>
>> Log Message:
>>
>> Add register definitions for AuXXXX SMBus protocol.
>>
>
> I wonder if this header name shouldn't have "psc" somewhere in the
> filename? These are register definitions that are specific to the
> PSC version of the SMBus controller right?
>
> Cheers,
> Simon.
> --
> Simon Burge <simonb@wasabisystems.com>
> NetBSD Support and Service: http://www.wasabisystems.com/
>
I agree. Isn't there an smbus controller on earlier Alchemy parts, that
doesn't go thru psc. E.g.: smbus_pscreg.h might be better.
--
Garrett D'Amore, Principal Software Engineer
Tadpole Computer / Computing Technologies Division,
General Dynamics C4 Systems
http://www.tadpolecomputer.com/
Phone: 951 325-2134 Fax: 951 325-2191