Subject: Re: CVS commit: [elad-kernelauth] src/sys
To: None <elad@NetBSD.org>
From: YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp>
List: source-changes
Date: 03/08/2006 18:55:13
> > - how about providing suser() as a wrapper of KAUTH_GENERIC_ISSUSER? (for now?)
>
> There are no more calls to suser() in this branch, why add them again?
because it's used often enough and easier to read?
> > - builtin_process seems like a too generic name to me.
>
> Explain please.
its name doesn't imply anything about its usage.
generally, exporting more symbols is a bad idea, esp. when
its name is too generic like this.
i think it's better to make it static and
move process_authorize to kern_auth.c.
also, for the same reason, function names in the TN
(kauth_authorize_process/kauth_authorize_generic) are better
than what you chose, IMO.
YAMAMOTO Takashi