Subject: Re: CVS commit: src/lib/libpcap
To: Christos Zoulas <christos@zoulas.com>
From: Matthias Drochner <M.Drochner@fz-juelich.de>
List: source-changes
Date: 03/20/2006 19:48:24
[src/lib/libpcap: gencode.c]
christos@zoulas.com said:
> A comment in the code would help.
Probably. But this is 3rd party code, and particulary
the "gencode" part underwent massive changes from both
upstream and NetBSD.
Judging which changes are worth keeping, and the merging
itself is hard. And each local change makes it harder.
In this case the problem is definitely on Coverity's side,
so I'd prefer to fix this rather than making maintainance
harder.
(Seeing the rush of commits in the last days I'm pretty
concerned about code quality decreasing. It has been the case
often enough that mechanical changes didn't do much good.)
best regards
Matthias