Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/arch/i386/bios



On 12-Apr-06, at 7:19 AM, Matthias Drochner wrote:


jmcneill%NetBSD.org@localhost said:
Modified Files:
        src/sys/arch/i386/bios: vesabios.c vesafb.c
Log Message:
* VBE functions return a byte, not a word. Ignore the
  rest of the garbage in the return register.

Uhm, this is wrong. The AH part is even more useful
than AL. "0" means "successful", other values are
error indications.
Have a look at the VBE spec for details.
(What might make sense is to mask out the upper 16 bits
of EAX because just AX is significant.)

Doh, I don't know what I was thinking. You're absolutely right. I'll fix this shortly.

Thanks!
Jared




Home | Main Index | Thread Index | Old Index