Re: CVS commit: src/sys/uvm

[christos%zoulas.com@localhost (Christos Zoulas)]

On Apr 14,  7:08am, yamt%mwd.biglobe.ne.jp@localhost (YAMAMOTO Takashi) wrote:
-- Subject: Re: CVS commit: src/sys/uvm

| > - So why check for it being NULL a few lines above?
| 
| do you mean this?
| 
|       if (entry->object.uvm_obj)
|               entry->offset += new_adj;       /* shift start over */
| 
| it can be NULL if !UVM_ET_ISOBJ(entry).

Right, what I am saying is that we should either be using:

        if (entry->object.uvm_obj)

or:
        if (UVM_ET_ISOBJ(entry))

consistently or even add the null test as a debugging aid inside the macro.
Using both is confusing.

christos