Subject: Re: CVS commit: src/sys/dev/ic
To: Pavel Cahyna <pavel@NetBSD.org>
From: Jeff Rizzo <riz@NetBSD.org>
List: source-changes
Date: 05/19/2006 14:49:15
This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig216DDD86995840B4B3196E34
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Pavel Cahyna wrote:
> On Wed, May 17, 2006 at 07:56:56AM +0900, YAMAMOTO Takashi wrote:
>  =20
>>> Module Name:	src
>>> Committed By:	pavel
>>> Date:		Tue May 16 22:39:24 UTC 2006
>>>
>>> Modified Files:
>>> 	src/sys/dev/ic: rtl8169.c
>>>
>>> Log Message:
>>> Disable hw VLAN tagging, in a similar way that it was done in OpenBSD=

>>> (src/sys/dev/ic/re.c rev. 1.15). The disabled VLAN stripping is mine.=

>>> (The OpenBSD driver forgot to do this.)
>>>
>>> The reason is that untagged packets get sometimes tagged incorrectly.=

>>> PR 32643.
>>>
>>> Approved by martin@.
>>>      =20
>
> Can I request a pull-up to netbsd-3? Unless we find a better fix. It wo=
uld
> be good to have VLANs on re working in 3.1, this hardware is very commo=
n.
>
> Pavel
>  =20

You committed the code;  if you can test in on netbsd-3, you can request
a pullup.  In fact, it's a good idea.  :)=20

+j



--------------enig216DDD86995840B4B3196E34
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iQCVAwUBRG49rrOuUtxCgar5AQOQcQP/fWym0Xg246Dp2hobUUdfkRuP0RDZl+ca
TIYg/IWepQIE4acUn79baXhGk1xpzEWbGKVlf3CPWnKLa/ffH1ChMl2pUWTei93q
Vwx2aShwl3mT9TpAPSIkSvqIMALq+SwxEtsmC+HYqi391BJp1mhjpJ3Jn+5u1GNh
/2wGcuOUtnw=
=3NfN
-----END PGP SIGNATURE-----

--------------enig216DDD86995840B4B3196E34--