Subject: Re: CVS commit: src/sys/kern
To: Perry E. Metzger <perry@piermont.com>
From: Frank Kardel <kardel@netbsd.org>
List: source-changes
Date: 07/14/2006 18:55:07
Perry E. Metzger wrote:
>Christos Zoulas <christos@netbsd.org> writes:
>
>
>>Module Name: src
>>Committed By: christos
>>Date: Fri Jul 14 15:52:44 UTC 2006
>>
>>Modified Files:
>> src/sys/kern: sys_generic.c
>>
>>Log Message:
>>- rename sleepts to sleeptv since it is a timeval.
>>- don't initialize it needlessly.
>>- fix the poll code the same way the select code was fixed, so that it
>> computes the remaining time to sleep properly.
>>
>>
>
>I bet there are similar bugs in the kqueue/kevent logic paths.
>
>
Almost similar. There seems to be a confusion in the code
about relative(tvtohz()) and absolute(hzto()) timestamps.
It seems that the tvtohz() conversion needs to be rechecked
for these things - grrr. This should have been discovered
earlier.
Simon, could you look at it? I'll have a look too and
pick up the kern_event.c file tonight.
Any other places that come to mind (will to a t{s,v}tohz() scan
anyway)?
>Perry
>
>
Frank