Subject: Re: CVS commit: src/sys/sys (protosw.h:1.39)
To: Jason Thorpe <thorpej@shagadelic.org>
From: Rui Paulo <rpaulo@fnop.net>
List: source-changes
Date: 08/29/2006 13:47:44
On Aug 29, 2006, at 4:29 AM, Jason Thorpe wrote:
>
> On Aug 28, 2006, at 5:51 PM, Christos Zoulas wrote:
>
>> Just to make things clearer, I am compiling kernels with -Wextra -
>> Wno-unused,
>> and these flags complain for incomplete structure initializers.
>
> Perhaps we should be using explicit structure initializers instead,
> e.g.
>
> struct foo aFoo = {
> .foo_field = 1,
> .foo_member = "woot",
> };
>
> Personally, I find:
>
> { .p_name = NULL }
>
> a lot nicer than
>
> { 0, NULL { 0, 0 }, NULL, { NULL, NULL } }
Strongly seconded.
-- Rui Paulo