On Sep 30, 2006, at 5:47 AM, Elad Efrat wrote:

> Firmload routines were using FSCRED, which in this case would get to  
> the
> NFS code and dereferenced, resulting in a panic. Use the credentials  
> from
> the LWP instead.

No, this is wrong.  The credentials used should always be the  
equivalent of "superuser" or "kernel credentials".  It might be some  
unpriv'd operation on the device that causes the driver to initiate a  
firmware re-load (which would be perfectly legitimate).

-- thorpej