Subject: Re: CVS commit: src/common/lib/libprop
To: Tom Spindler <dogcow@babymeat.com>
From: Jason Thorpe <thorpej@shagadelic.org>
List: source-changes
Date: 10/16/2006 11:03:27
On Oct 16, 2006, at 9:14 AM, Tom Spindler wrote:
> There's also other warnings/build breakages generated on x86_64 in
> lib/libprop
> with _PROP_CALLOC in userland, "fixed" by changing
>
> -#define _PROP_CALLOC(s, t) calloc(1, (s))
> +#define _PROP_CALLOC(s, t) calloc((size_t) 1, (s))
>
> in prop_object_impl.h - but I'll let you fix it as you deem
> appropriate.
This is a completely bogus fix. IMO, lint(1) is out of line warning
about a constant argument that falls within the valid range of the
data type of that argument.
-- thorpej