Subject: Re: CVS commit: src/sys/dev/pci
To: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
From: Stephen M. Rumble <stephen.rumble@utoronto.ca>
List: source-changes
Date: 12/23/2006 19:49:47
Quoting Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>:
> rumble@NetBSD.org wrote:
>
>> Module Name: src
>> Committed By: rumble
>> Date: Sat Dec 23 21:24:32 UTC 2006
>>
>> Modified Files:
>> src/sys/dev/pci: if_tl.c
>>
>> Log Message:
>> The Set Engineering GIO board for sgimips (IP22) sits behind a special
>> bridge that precludes the ThunderLAN's DMA engine from performing segment
>> transfers across page boundaries. Add logic under #ifdef TL_SETENG_GFE to
>> split up these segment transfers appropriately.
>
> - This #ifdef should be replaced by prop_dictionary
> (see dev/pci/ahc_pci.c and sgimips/autoconf.c)
> - I think this boundary restriction could be handled by an arg of
> bus_dmamap_create(9) and you don't have to split segments manually
Ah, excellent. This is much better -- I'll make the appropriate
changes right now!
Steve