Subject: Re: CVS commit: src/sbin/init
To: Christian Biere <christianbiere@gmx.de>
From: Elad Efrat <elad@NetBSD.org>
List: source-changes
Date: 02/06/2007 18:01:58
Christian Biere wrote:
> David Laight wrote:
>
>> There is absolutely nothing wrong woth functions having multiple 'return'
>> statments in order to save the human reader having to parse the rest of
>
> That cannot be generalized. This has to be decided on a case-by-case basis
> and in many cases either option has no advantage over the other. The
> disadvantage of multiple return statements are:
>
> * more code
> * variables exist in scopes in which they are not used.
> * can easily cause resource leaks
>
> Deeply nested code should be avoided but I don't find that a depth of up to 3
> levels is unreadable.
I agree. the previous code was horrible; I think it's much cleaner now.
please let's keep it that way, and please let's use single exit point
where possible.
-e.