Subject: Re: CVS commit: src/lib/libkvm
To: Elad Efrat <elad@NetBSD.org>
From: Andrew Doran <ad@netbsd.org>
List: source-changes
Date: 02/08/2007 17:11:56
On Wed, Feb 07, 2007 at 03:42:23AM +0200, Elad Efrat wrote:
> Andrew Doran wrote:
>
> > Thanks for fixing this. Redefining kauth_cred_t in userland isn't the right
> > way to go about it though. Please change it so that kauth_cred_t is defined
> > in a non-installed header file under sys/sys.
>
> I'd rather not. Having it exposed in sys/sys is just asking for people
> to access its members directly.
If others do access it directly, that's not your problem - it's theirs. All
you need to do is document it as implementation private, and protect it with
a define.
Will you be fixing this?
Cheers,
Andrew