Subject: Re: CVS commit: src/sys/kern
To: Andrew Doran <ad@netbsd.org>
From: Tom Spindler <dogcow@NetBSD.org>
List: source-changes
Date: 06/18/2007 02:42:15
> Modified Files:
> src/sys/kern: kern_lock.c
>
> Log Message:
> Nuke __HAVE_SPLBIGLOCK.
This breaks compiles with !defined(MULTIPROCESSOR) && defined(LOCKDEBUG):
kern_rwlock.o: In function `rw_vector_enter':
/usr/src/sys/kern/kern_rwlock.c:231: undefined reference to `kernel_lock'
The relevant section of code is this:
#ifdef LOCKDEBUG
if (panicstr == NULL) {
simple_lock_only_held(NULL, "rw_enter");
LOCKDEBUG_BARRIER(&kernel_lock, 1);
}
#endif
Is the proper fix to #ifdef the LOCKDEBUG_BARRIER bit, or to nuke it
entirely?