Subject: Re: CVS commit: [itohy-usb1] src/sys/dev/usb
To: None <juan@xtrarom.org>
From: M. Warner Losh <imp@bsdimp.com>
List: source-changes
Date: 06/23/2007 00:05:31
In message: <20070622124622.8ff360bd.juan@xtrarom.org>
Juan RP <juan@xtrarom.org> writes:
: On Fri, 22 Jun 2007 10:44:57 +0000 (UTC)
: ITOH Yasufumi <itohy@netbsd.org> wrote:
:
: >
: > Module Name: src
: > Committed By: itohy
: > Date: Fri Jun 22 10:44:56 UTC 2007
: >
: > Modified Files:
: > src/sys/dev/usb [itohy-usb1]: if_aue.c if_cdce.c if_cue.c if_kue.c
: > if_udav.c if_url.c
: >
: > Log Message:
: > Execute callback functions as tasks on FreeBSD.
: > (FYI, the code does work on NetBSD, but affects the performance, you
: > know.)
:
: Is there any reason to keep the #ifdef __OtherBSD__ anymore? even FreeBSD
: and OpenBSD removed these parts.
FreeBSD removed most of the #ifdefs because the code simply didn't
work on the OtherBSDs. We retained the usb_port.h file for drivers
that wanted to be portable. The #ifdefs deeper in the usb code did
nothing but obscure bugs in our tree, since it hadn't been well
maintained.
Warner