Subject: Re: CVS commit: src/sys/arch/xen/i386
To: None <bouyer@netbsd.org>
From: YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp>
List: source-changes
Date: 06/26/2007 08:23:49
> Module Name: src
> Committed By: bouyer
> Date: Mon Jun 25 20:09:34 UTC 2007
>
> Modified Files:
> src/sys/arch/xen/i386: spl.S vector.S
>
> Log Message:
> Various cleanups in interrupt code, and fix a potential crash in doreti:
> if we enter doreti_checkast with only soft interrupt pendings, we would
> jump to one of the soft* vector with %esi uninitialized, and the vector
> would do a jump *%esi at the end ...
> I don't know why nobody ever went into this; I guess in the common case
> there's no soft irq pending without a hard irq in this code path ...
my understanding is that it can't happen because, when jumped from
hypervisor_callback, doreti doesn't lower ipl.
YAMAMOTO Takashi
>
>
> To generate a diff of this commit:
> cvs rdiff -r1.8 -r1.9 src/sys/arch/xen/i386/spl.S
> cvs rdiff -r1.17 -r1.18 src/sys/arch/xen/i386/vector.S
>
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.