Subject: Re: CVS commit: src/sys/dev/sysmon
To: Juan RP <juan@xtrarom.org>
From: Jason Thorpe <thorpej@shagadelic.org>
List: source-changes
Date: 07/20/2007 09:09:42
On Jul 20, 2007, at 4:58 AM, Juan RP wrote:
> On Fri, 20 Jul 2007 20:31:27 +0900 (JST)
> yamt@mwd.biglobe.ne.jp (YAMAMOTO Takashi) wrote:
>
>>> Module Name: src
>>> Committed By: xtraeme
>>> Date: Fri Jul 20 10:40:08 UTC 2007
>>>
>>> Modified Files:
>>> src/sys/dev/sysmon: sysmon_envsys.c sysmon_envsys_events.c
>>> sysmon_envsysvar.h
>>>
>>> Log Message:
>>> Replace the macros to create/update objects in dictionary with three
>>> inline functions, suggested by yamt@.
>>>
>>> This also gets rid of a few gotos.
>>
>> why inline?
>
> I thought inline was ok for these functions, is there any reason to
> not make
> them inline?
It makes the code unnecessarily bigger, in some cases.
>
>
> --
> Juan Romero Pardines - The NetBSD Project
> http://plog.xtrarom.org - NetBSD/pkgsrc news in Spanish
-- thorpej