Subject: Re: CVS commit: [vmlocking] src/sys
To: YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp>
From: Andrew Doran <ad@netbsd.org>
List: source-changes
Date: 07/30/2007 12:57:20
On Mon, Jul 30, 2007 at 11:29:09AM +0900, YAMAMOTO Takashi wrote:
> > Trap free() of areas that contain undestroyed locks. Not a major problem
> > but it helps to catch bugs.
>
> how about making lockdebug_lookup use the hash as well, and kill lock id?
I wanted to avoid that so LOCKDEBUG was not so slow. There again, LOCKDEBUG
doesn't really need to be quick. It only needs to _not_ make the machine
unusable.
I think this is a good idea. lockdebug_lookup() could do with a different
method of hashing that takes the lower order bits into consideration - I'll
investigate that.
Andrew