Subject: CVS commit: [newgrp-standalone] src/usr.bin/newgrp
To: None <source-changes@NetBSD.org>
From: Brian Ginsbach <ginsbach@netbsd.org>
List: source-changes
Date: 10/28/2007 03:13:37
Module Name: src
Committed By: ginsbach
Date: Sun Oct 28 03:13:37 UTC 2007
Modified Files:
src/usr.bin/newgrp [newgrp-standalone]: newgrp.c
Log Message:
Fix additional bugs in original newgrp(1) implementation.
- Fix compile errors in conditionally compiled code
(!(defined(BSD) && BSD >= 199306)) as noted by Anon Ymous.
- Don't do anything with the supplementary group list when the new and old
groups are the same. (Based on discussions with Anon Ymous.)
+ This fixes a potential bug in the conditionally compiled code
(!(defined(BSD) && BSD >= 199306)). In this case the new group
is incorrectly added to the supplementary list on a system where
the effective group is not in this list.
+ This also simplifies processing on systems where the effective
group is normally in the supplementary list.
- Handle unexpected errors in the addgrp function more consistently
by using warn(3) throughout the function.
To generate a diff of this commit:
cvs rdiff -r1.3 -r1.3.2.1 src/usr.bin/newgrp/newgrp.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.